pydra icon indicating copy to clipboard operation
pydra copied to clipboard

adding test for 2 inner wfs with various numbers of processors

Open djarecka opened this issue 6 years ago • 3 comments

Summary

@satra - adding the test you asked for

Checklist

  • [ ] All tests passing
  • [ ] I have added tests to cover my changes
  • [ ] I have updated documentation (if necessary)
  • [x] My code follows the code style of this project (we are using black: you can pip install pre-commit, run pre-commit install in the pydra directory and black will be run automatically with each commit)

Acknowledgment

  • [x] I acknowledge that this contribution will be available under the Apache 2 license.

djarecka avatar Aug 02 '19 18:08 djarecka

Codecov Report

Merging #115 into master will increase coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   86.92%   87.13%   +0.21%     
==========================================
  Files          16       16              
  Lines        2332     2332              
  Branches      570      570              
==========================================
+ Hits         2027     2032       +5     
+ Misses        210      206       -4     
+ Partials       95       94       -1
Flag Coverage Δ
#unittests 87.13% <ø> (+0.21%) :arrow_up:
Impacted Files Coverage Δ
pydra/engine/workers.py 81.29% <0%> (-1.44%) :arrow_down:
pydra/utils/profiler.py 44.77% <0%> (+5.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2083ae8...3b1a356. Read the comment docs.

codecov[bot] avatar Aug 13 '19 17:08 codecov[bot]

@satra - I'm not sure if that was the test that you were expecting to check different number of processors.

djarecka avatar Aug 13 '19 17:08 djarecka

i'll close this for now, and perhaps we can rethink this in the context of resource managers for different workers.

satra avatar Aug 27 '19 01:08 satra

Closure didn't happen, but no change in 4 years.

effigies avatar Jun 30 '23 01:06 effigies