nipype icon indicating copy to clipboard operation
nipype copied to clipboard

Fixed bug for work dirs longer than 255 characters, fixes #2061

Open prioux opened this issue 2 years ago • 1 comments

Summary

This change is fully backwards compatible and will not affect existing pipelines, but it will prevent the pipeline engine from crashing when some parameters are long and it was trying to create subdirectories longer than 255 characters (a typical unix limit).

Fixes #2061 .

prioux avatar Jul 21 '22 20:07 prioux

Codecov Report

Merging #3495 (0094bed) into master (ff8e514) will increase coverage by 1.69%. The diff coverage is 100.00%.

:exclamation: Current head 0094bed differs from pull request most recent head 97c05fb. Consider uploading reports for the commit 97c05fb to get more accurate results

@@            Coverage Diff             @@
##           master    #3495      +/-   ##
==========================================
+ Coverage   63.62%   65.31%   +1.69%     
==========================================
  Files         309      309              
  Lines       40855    40965     +110     
  Branches     5379     5384       +5     
==========================================
+ Hits        25995    26758     +763     
+ Misses      13835    13134     -701     
- Partials     1025     1073      +48     
Flag Coverage Δ
unittests 65.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/pipeline/engine/nodes.py 79.04% <100.00%> (-0.04%) :arrow_down:
nipype/pipeline/engine/utils.py 75.20% <100.00%> (+1.37%) :arrow_up:
nipype/interfaces/afni/preprocess.py 81.55% <0.00%> (+0.54%) :arrow_up:
nipype/interfaces/spm/preprocess.py 50.28% <0.00%> (+0.84%) :arrow_up:
nipype/interfaces/freesurfer/model.py 63.73% <0.00%> (+1.09%) :arrow_up:
nipype/utils/subprocess.py 86.66% <0.00%> (+1.48%) :arrow_up:
nipype/interfaces/freesurfer/preprocess.py 66.04% <0.00%> (+1.65%) :arrow_up:
nipype/interfaces/base/core.py 87.96% <0.00%> (+2.33%) :arrow_up:
nipype/interfaces/base/specs.py 88.77% <0.00%> (+2.55%) :arrow_up:
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 21 '22 20:07 codecov[bot]