nipype icon indicating copy to clipboard operation
nipype copied to clipboard

fsl.MotionOutliers output spec no longer requires out_file to exist

Open beausievers opened this issue 8 years ago • 3 comments

fsl.MotionOutliers output spec no longer requires out_file to exist. fsl_motion_outliers does not create an output file when no timepoints are above the threshold, and in this situation fsl.MotionOutliers would throw a FileNotFoundError. This pull request fixes that immediate problem.

beausievers avatar Apr 10 '16 15:04 beausievers

Coverage Status

Coverage remained the same at 72.538% when pulling 95b4fc8ba644fcb7d321c84218de1fd957d85ab8 on beausievers:master into 4b392d55e469290139fc63d1a95928d665a2b08d on nipy:master.

coveralls avatar Apr 10 '16 15:04 coveralls

@oesteban, @chrisfilo - we need to come up with a reasonable solution before this release. turns out the file is not created when the threshold does not result in any outliers. i was going to write a list outputs for this interface, but do you think we could have the following pattern.

if metadata exists does not exist
   and file pattern created by name_template does not match an existing file
then keep output undefined

satra avatar Apr 12 '16 12:04 satra

@satra @oesteban has this been solved or should we merge this? related to #1427

mgxd avatar Apr 04 '17 19:04 mgxd