heudiconv icon indicating copy to clipboard operation
heudiconv copied to clipboard

make heudiconv TODOs break bids-validator

Open satra opened this issue 5 years ago • 2 comments

Summary

i have seen some datasets converted that have TODOs but pass the validator, but fail when people are trying to run downstream scripts/workflows. i think heudiconv should intentionally force people to address the TODOs by making those files fail validation. the easy example to point to is events.tsv.

satra avatar Jul 29 '20 17:07 satra

Do you have an example of a script/workflow which trips? AFAIK all our todos as following the bids spec and thus validator is silent. Events file included. I suspect that may be the tools you had in mind are buggy? ;-) I will not charge their developers for the awesome test cases heudiconv provides them with to help them catch all the bugs ;-)

Having said all that I wouldn't mind validator having a dedicated warning to alert about todos

yarikoptic avatar Jul 30 '20 04:07 yarikoptic

fitlins breaks on bunch of things depending on what stats models is being evaluated, but the one that tripped it most recently was an empty events.tsv for one session but not another.

satra avatar Jul 30 '20 10:07 satra