Nipunn Koorapati

Results 132 comments of Nipunn Koorapati

I'm not a mod - but I've been here following with this task for 3+ years now. Here's a writeup of my summary - from reading through this. > *...

I'm not sure if the idea I gave for this problem is actually achievable. In reading up, I found: Deserializer for struct might look like this https://serde.rs/deserialize-struct.html The wrapping deserializer...

looks lovely! Thanks for the PR! From my reading of the docs of GRPC - it seems that AIO is trying to replace the original server Seems like there are...

I believe it depends on shabbyrobe/grpc-stubs#22 - so we can import from `grpc.aio` I quickly tried to pick this up and got ``` test/generated/testproto/grpc/import_pb2_grpc.pyi:8: error: Skipping analyzing "grpc.aio": found module...

I believe we want to generate something like this ```python class DummyServiceServicer: def UnaryUnary(self, request: DummyRequest, context: grpc.ServicerContext, ) -> typing.Union[DummyReply, typing.Awaitable[DummyReply]]: ... def add_DummyServiceServicer_to_server( servicer: DummyServiceServicer, server: typing.Union[grpc.Server, grpc.aio.AioServer])...

> After some deliberation, It seemed impractical to combine the definition for AIO/non-AIO servicers. This is primarily because the ServicerContext that is passed into the functions has some different members....

I wrote up #276 - to give you a starting point for the ideas above. It's not really useful on its own, but just wanted to give you something so...

That logic makes sense. The sync/async is a question of implementation, not of spec. There's still a couple of shortcomings to the flag approach - Flags are hard to maintain...