smriprep icon indicating copy to clipboard operation
smriprep copied to clipboard

adding giftis for thickness curvature and sulcal depth

Open ericfeczko opened this issue 3 years ago • 3 comments

This address issue #288. I'm running into some errors with the outputs due to some syntax issues that were introduced. Will be doing some testing with circle CI today to debug. Will also ensure pep8 compatibility.

ericfeczko avatar Jul 21 '22 12:07 ericfeczko

@ericfeczko The requirement that we find the right ?h.white (or ?h.smoothwm) for this is pushing logic that should be into the interface into the workflow. I think a cleaner solution is to make a new interface that just sub-classes MRIsConvert and infers the correct in_file if scalarcurv is passed. WDYT?

effigies avatar Jul 21 '22 18:07 effigies

that sounds perfect -- I'm in meeting hell right now, but I can try to give this a shot tonight or tomorrow.

ericfeczko avatar Jul 21 '22 18:07 ericfeczko

Here's an (untested) attempt: 857e0bd8370d967691dc11d9ca7b705e63efb394

You may need to add my fork to try it out:

git remote add effigies https://github.com/effigies/smriprep.git
git fetch effigies
git cherry-pick 857e0bd

effigies avatar Jul 21 '22 18:07 effigies

What are the expected outputs? I guess .dscalar.nii or .shape.gii?

effigies avatar Oct 13 '22 18:10 effigies

Closed by #305

mgxd avatar Oct 18 '22 14:10 mgxd