sdcflows icon indicating copy to clipboard operation
sdcflows copied to clipboard

Repair 3dQwarp workflow

Open psadil opened this issue 1 year ago • 4 comments

Closes #441

This repairs the 3dQwarp workflow. As before, 3dQwarp is used to generate a displacement field and correct the reference image.

As per discussion with @effigies during Brainhack 2024, the repairs were done so that the workflow now matches the topup workflow in terms of outputs and inputs. The repaired workflow now also returns an estimated fieldmap and the coefficients for a bspline fit to the fieldmap. Note that this means that the unwarped image returned in fmap_ref is in general not what one would get by reconstructing the fieldmap from fmap_coeff and unwarping the reference image in in_data.

psadil avatar Jul 07 '24 01:07 psadil

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.46%. Comparing base (08e198f) to head (dd5f251).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   76.40%   76.46%   +0.06%     
==========================================
  Files          32       32              
  Lines        2814     2830      +16     
  Branches      376      378       +2     
==========================================
+ Hits         2150     2164      +14     
- Misses        597      598       +1     
- Partials       67       68       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 07 '24 01:07 codecov[bot]

@psadil Sorry about the long delay. I'm marking this as draft just so I know that it's waiting on you. Please feel free to mark as ready again whenever you get back to this.

effigies avatar Oct 04 '24 19:10 effigies

@psadil Sorry about the long delay. I'm marking this as draft just so I know that it's waiting on you. Please feel free to mark as ready again whenever you get back to this.

Sorry it's taking me so long to respond to your review! I'm aiming to be able to get to this by the end of next week.

psadil avatar Oct 04 '24 22:10 psadil

uh oh, seems like I may have messed things up with that force push?

psadil avatar Oct 17 '24 01:10 psadil