niworkflows
niworkflows copied to clipboard
Expand fMRIPlot to be non-specific to modality
I'd like to contribute a change to make fMRIPlot more generalize-able to other modalities.
What I have in mind is removing the dependence on func_file being supplied. That way the carpet plot would only be generated if a time-series was supplied, but that any confound could be plotted in any report type using the existing plotting functionality.
The use case for this is this proposed change.
Hi @hacevedo, sorry for the delay on getting back to you. I think this change sounds reasonable, though it might end up making more sense to create a separate time series plot interface that reuses a lot of code from fMRIPlot. If you're up for it, would you like to submit a PR with what you're thinking about, and we can then discuss whether it makes sense to keep as a single interface or split out?