fmriprep icon indicating copy to clipboard operation
fmriprep copied to clipboard

24.x series not sending finished heartbeat to Sentry?

Open oesteban opened this issue 11 months ago • 4 comments

What happened?

While we record started runs for the 24.x series, we are not collecting a single success ping. We may have accidentally discontinued that?

What command did you use?

n/a

What version of fMRIPrep are you running?

24.x

How are you running fMRIPrep?

Other

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

oesteban avatar Jan 02 '25 15:01 oesteban

What about 23.2? There should have been very little change infrastructure change between 23.2 and 24.0.

effigies avatar Jan 02 '25 15:01 effigies

We do see some records:

>>> versions_success.sum(axis=0)

20.2    158597.0
21.0    152072.0
22.0     85018.0
22.1     88046.0
23.0     89596.0
23.1    223020.0
23.2     94983.0
dtype: float64
>>> versions_started.sum(axis=0)

20.2     195312.0
21.0     169621.0
22.0      95871.0
22.1      98161.0
23.0     113328.0
23.1     352331.0
23.2     226747.0
24.0      69818.0
24.1      70409.0
older     35903.0
dtype: float64

That said, there seems to be a considerable performance drop for 23.2 (94983 successful / 226747 started)

oesteban avatar Jan 02 '25 16:01 oesteban

Just comparing, I don't see a reason in our code that it should have changed:

https://github.com/nipreps/fmriprep/compare/23.1.4...24.1.1#diff-ece308de006691ca422e8aab537468cd6937ca6e683ce4d91918412b6912ce99R140-R147

Though we did bump major versions of sentry_sdk:

https://github.com/nipreps/fmriprep/compare/23.1.4...24.1.1#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552L288-R438

Could be a behavior change we didn't notice?

effigies avatar Jan 02 '25 16:01 effigies

Another possibility is that the success heartbeat is misreporting the version string.

oesteban avatar Jan 02 '25 16:01 oesteban