fmriprep icon indicating copy to clipboard operation
fmriprep copied to clipboard

Report clearly bids filters

Open celprov opened this issue 1 year ago • 3 comments

What would you like to see added in fMRIPrep?

It would be nice that the bids filters were reported very clearly in the log file (and perhaps make them also appear in the config)

cc/ @oesteban

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

celprov avatar Sep 27 '23 00:09 celprov

cc/ @bpinsard - I think I remember he implemented the earliest version of filters?

oesteban avatar Sep 27 '23 07:09 oesteban

They should appear in config.execution.bids_filters. Unless you mean you want the final filters, when merged with the default filters, i.e., the queries variable at the end of:

https://github.com/nipreps/niworkflows/blob/master/niworkflows/utils/bids.py#L228-L244

effigies avatar Sep 27 '23 19:09 effigies

I confirm that the filters do appear in the config.toml. Logging the final one should be easy to implement. Adding these to the html reports might require more work.

bpinsard avatar Sep 30 '23 01:09 bpinsard