fmriprep icon indicating copy to clipboard operation
fmriprep copied to clipboard

BF(DOC): use a BIDS compliant _mask instead of old BEP03 _roi to point to lesion mask

Open yarikoptic opened this issue 3 years ago • 4 comments

Not sure if the specific name is the best one, since does not point explicitly to T1w as the orig of that mask, and either label should may be made extended instead of abbreviated L.

But in either case, old doc example is clearly wrong thus this fix

Attn @michael-sun

yarikoptic avatar Feb 15 '22 16:02 yarikoptic

Before we can update the docs, we need to accept the standard ROI masks.

effigies avatar Feb 15 '22 16:02 effigies

oh, right... I have tried to spot which code is relying on those _roi files but failed to find any.

yarikoptic avatar Feb 15 '22 20:02 yarikoptic

Codecov Report

Merging #2715 (940d7e1) into master (7dcf0eb) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2715   +/-   ##
=======================================
  Coverage   46.63%   46.63%           
=======================================
  Files          44       44           
  Lines        3270     3270           
=======================================
  Hits         1525     1525           
  Misses       1745     1745           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dcf0eb...940d7e1. Read the comment docs.

codecov-commenter avatar Feb 15 '22 20:02 codecov-commenter

It's in smriprep. Apologies for the web of dependencies; the idea is to make identical anatomical preprocessing available to dmriprep or aslprep or whatevercomesnextprep.

effigies avatar Feb 15 '22 21:02 effigies

Docs are being updated to match behavior in #2943. They will be updated again when behavior conforms to BIDS Derivatives spec, targeting 23.1.0.

effigies avatar Jan 27 '23 15:01 effigies