ENH: add flag --high-pass-filter for custom filtering cutoff
Changes proposed in this pull request
ref #1961
Documentation that should be reviewed
Thanks for opening this pull request! It looks like this is your first time contributing to fMRIPrep. :smile:
We invite you to list yourself as an fMRIPrep contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order, into the contributors.json file. Example:
"name": "Contributor, New FMRIPrep",
"affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
"orcid": "<your id>"
}, ```
Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.
Thank your for raising your pull request.
Some of the fMRIPRep maintainers will review your changes as soon as time permits. I'm attaching below a Review Checklist for the reviewers, to check off during the review.
PR Review
Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
- [ ] As the reviewer I confirm that there are no conflicts of interest for me to review this work.
Please check what applies in the following aspects of the PR:
Code documentation
- [ ] New functions and modules are documented following the guidelines.
- [ ] Existing code required amendments in documentation and has been updated.
- [ ] Sufficient inline comments ensure readability by other contributors in the long term.
Documentation site
- [ ] The modifications to fMRIPrep in this PR do not require extra documentation. This is a common situation when a bug fix that does not change the code base substantially is submitted.
- [ ] This PR requires documentation. The corresponding documentation will be submitted as an additional PR in the future.
- [ ] This PR requires extra documentation, and will be included within this PR. Please check the boxes that apply best:
- [ ] An existing feature is substantially modified, changing the interface and/or logic of a module.
- [ ] A new feature is being added, therefore full documentation of it will be included
- [ ] This PR addresses an error in existing documentation.
- [ ] Yes, all expected sections of documentation were generated by the CI build, and look as expected
Tests
- [ ] The new functionalities in this PR are covered by the existing tests
- [ ] New test batteries have been included with this PR
Data
- [ ] This PR does not require any additional data to be uploaded to OSF.
- [ ] This PR requires additional data for tests.
Dependencies: smriprep
- [ ] This PR does not require any update on
smriprep; or - [ ]
smriprephas correctly been pinned.
Dependencies: niworkflows
- [ ] This PR does not require any update on
niworkflows; or - [ ]
niworkflowshas correctly been pinned.
Dependencies: sdcflows
- [ ] This PR does not require any update on
sdcflows; or - [ ]
sdcflowshas correctly been pinned.
Dependencies: Nipype
- [ ] This PR does not require any update on
nipype; or - [ ]
nipypehas correctly been pinned.
Dependencies: other
- [ ] This PR does not require any update on other dependencies; or
- [ ] other dependencies have correctly been pinned.
Reports generated within CI tests
- [ ] Yes, I have checked the reports of ds005 and they are not modified or the changes are as expected
- [ ] Yes, I have checked the reports of ds054 and they are not modified or the changes are as expected
- [ ] Yes, I have checked the reports of ds010 and they are not modified or the changes are as expected
Hi! Not sure how this got completely ignored for 1.5 years... There are a number of conflicts with master now, if you'd like to merge/rebase.
Please rebase and reopen if this is still of interest. Apologies again for letting this slide without response for so long.