dmriprep
dmriprep copied to clipboard
[ENH] Add emc helper functions - vectors
*All of these support the signal prediction routines. *Each function will need a unit test.
Best reviewed: commit by commit
Optimal code review plan (1 warning)
[ENH] Add API to vectors for reorienting bvecs from rasb .tsv and affi...
dmriprep/utils/vectors.py69% changes removed in Add signal predictio...
[ENH] Add API to vectors for reorienting bvecs from rasb .tsv and affi...
Merge remote-tracking branch 'upstream/master'
Add signal prediction vector handling functions
Add doctest to non_overlapping_qspace_samples, made general-purpose
Update dmriprep/utils/vectors.py
Change exception error to user warning in normalize gradients
Powered by Pull Assistant. Last update 5f51f9d ... 8b365f8. Read the comment docs.
Hello @dPys, Thank you for updating!
Cheers! There are no style issues detected in this Pull Request. :beers: To test for issues locally, pip install flake8 and then run flake8 dmriprep.
Comment last updated at 2020-03-24 20:09:36 UTC
Codecov Report
Merging #76 into master will decrease coverage by
0.59%. The diff coverage is100%.
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
- Coverage 52.37% 51.77% -0.6%
=========================================
Files 16 21 +5
Lines 907 1240 +333
Branches 114 164 +50
=========================================
+ Hits 475 642 +167
- Misses 431 586 +155
- Partials 1 12 +11
| Impacted Files | Coverage Δ | |
|---|---|---|
| dmriprep/utils/vectors.py | 90.1% <100%> (-9.9%) |
:arrow_down: |
| dmriprep/config/__init__.py | 56.72% <0%> (-43.28%) |
:arrow_down: |
| dmriprep/cli/run.py | 4.1% <0%> (-26.3%) |
:arrow_down: |
| dmriprep/workflows/base.py | 24.67% <0%> (-4.91%) |
:arrow_down: |
| dmriprep/interfaces/vectors.py | 100% <0%> (ø) |
:arrow_up: |
| dmriprep/__init__.py | 100% <0%> (ø) |
:arrow_up: |
| dmriprep/utils/images.py | 13.33% <0%> (ø) |
|
| dmriprep/cli/parser.py | 56.57% <0%> (ø) |
|
| dmriprep/utils/misc.py | 50% <0%> (ø) |
|
| ... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 127a65d...8b365f8. Read the comment docs.