Extending or Aliasing a Class

[ghost]

Example, I have to tags that are identical, except the tag names are different.

@template(`<hero-form><yield/></hero-form>`)
export class HeroForm extends Riot.Element implements IHeroForm {
      getContainer():JQuery {},
      mounted():void {},
      bindSumbit():void {}
}

// ... later 

@template(`<enquire-form><yield/></enquire-form>`)
export class EnquireForm extends HeroForm {

  constructor(){
    super();
  }

  getContainer():Jquery {
   return super.getContainer();
  }

mounted():void {
   return super.mounted();
  }
 /// ...etc, this seems dirty to me, but aside from using a mixin can this be implemented better?
}

Am I missing something here? I have to keep calling the super on the child class otherwise I lose context.

[nippur72]

It seems there's a problem in the way we transfer properties from the typescript class object to the riot tag object. The transfer is limited to properties in element.prototype only and thus it does not consider the chain of inheritance.

In other words it copies methods and properties from the class but skipping methods and properties from its ancestors. Normally this isn't a problem because most of the times you extend from Riot.Element, and I guess that's why we haven't noticed the issue before.

I will mark this as a bug, but I expect it to be automatically fixed with riot 3, since we will have a true ES6 Riot.Tag class to extend from.

[ghost]

Ok. Thanks for update.

I can't see this being too much of an issue at the moment. I will just use the super calls and refactor it later when riot 3 arrives.

Thank you.