condomjs icon indicating copy to clipboard operation
condomjs copied to clipboard

Big Picture: Reverse Comparison

Open RonHolt opened this issue 5 years ago • 1 comments

I think we are missing the big picture here. Isn't the point of the <Condom> wrapper to NOT render <Children /> while B==D (at least 98% of the time)?

I propose the following:

  • When using the <Condom> wrapper, that <Children /> are rendered only 2% of the time (at random).
  • Then if <Condom> wrapper is used strictly (with the isHard prop), it should render <Children /> only 1% of the time.

Finally for safety, I know this is not strictly related, but perhaps we could include a friendly reminder in the README.md file to always sanitize your inputs before inserting into the back end.

RonHolt avatar Dec 10 '20 20:12 RonHolt

Shouldn't isHard increase the probability of render? Because is hard is related to the penis.js library, so your logic seems like an opposite to me

sotnii avatar Jan 31 '24 14:01 sotnii