obsplus icon indicating copy to clipboard operation
obsplus copied to clipboard

df to inventory get response fails on CI

Open d-chambers opened this issue 1 year ago • 2 comments

Description Currently test_stations_utils.py::TestDfToInventoryGetReponses::test_get_station_client fails in CI, but works locally (on my machine 😉).

This test reaches out to Pascal data services (formally IRIS) to get response information to create an inventory. It works locally but fails in CI. I wonder if Pascal data services gets too many requests from GH actions so it is getting rejected?

Anyway, I am going to kick the can down the road on this one because I know there are other changes coming to PDS soon that we will have to deal with from an ObsPy level.

d-chambers avatar Jul 21 '23 18:07 d-chambers

It appears our doc build is failing as well related to this issue, see here.

d-chambers avatar Jul 21 '23 19:07 d-chambers

I think this is a different issue, but wanted to make sure this wasn't also related to #271 , since the timing is about right for when that started being a thing.

shawnboltz avatar Apr 02 '24 23:04 shawnboltz

@d-chambers I think this should be fixed now? I tweaked df_to_inventory a while back to be compatible with obspy's change to how they handle the NRL, so those tests should pass now. The solution I had to come up with was less than ideal, but there's not really anything we can do about it.

shawnboltz avatar Nov 12 '24 22:11 shawnboltz

Ok, so the test passes now? Feel free to close if so.

d-chambers avatar Nov 13 '24 01:11 d-chambers

Ok, so the test passes now? Feel free to close if so.

In theory, yes. In practice, it looks like the CI is broken (specifically it's failing to install obsplus).

shawnboltz avatar Nov 13 '24 01:11 shawnboltz

Oh, that's not good 😟. I will try to take a look later this week.

d-chambers avatar Nov 13 '24 02:11 d-chambers