symfony-collection icon indicating copy to clipboard operation
symfony-collection copied to clipboard

postInstall and postUpdate script when having a shared vendor folder

Open picks44 opened this issue 7 years ago • 9 comments

I can see that the postInstall and postUpdate scripts to copy the two files are based on the relative path of the Vendors folder. But in my project this folder is shared, so the scripts are failing.

Could you maybe provide a solution for this or update the scripts to it's based on the root of the project maybe?

picks44 avatar Sep 05 '17 13:09 picks44

Hi,

Sure, I didn't consider this case. Will check the Composer API to find a solution tomorrow night.

Cheers

ninsuo avatar Sep 05 '17 16:09 ninsuo

@ninsuo awesome, thanks !

picks44 avatar Sep 05 '17 17:09 picks44

This wasnt't that easy but I found a way.

The point is that the "baseDir" stored in composer configuration is a private property without getter... So I need to use extras parameters to let you write an optional destination path for the view and the asset.

ninsuo avatar Sep 06 '17 22:09 ninsuo

Hi @ninsuo, any update on this ?

picks44 avatar Sep 18 '17 09:09 picks44

Hello @picks44 and sorry for the delay. I'm working abroad right now and will come back next week. Thanks for your patience,

ninsuo avatar Sep 18 '17 14:09 ninsuo

No worries! :)

picks44 avatar Sep 18 '17 14:09 picks44

@ninsuo doas the new version solve this issue?

picks44 avatar Oct 17 '17 10:10 picks44

Hey picks44,

No I didn't fix this issue yet, sorry about that... I'm working on many projects and prioritize on the ones that gather money.

Can you try to provide a workaround and create a PR?

I'll try to find some time working on it but those days are tough.

ninsuo avatar Oct 17 '17 11:10 ninsuo

Alright I'll try, but I'm no specialist :/ but I'll try ;)

picks44 avatar Oct 17 '17 11:10 picks44