symfony-collection icon indicating copy to clipboard operation
symfony-collection copied to clipboard

Unexpected "endspaceless" tag (expecting closing tag for the "apply" tag defined near line 24).

Open picks44 opened this issue 5 years ago • 9 comments

Hi, since upgrade to v2.1.32, I get this error :

Unexpected "endspaceless" tag (expecting closing tag for the "apply" tag defined near line 24).

Twig\Error\
SyntaxError
in app\Resources\views\jquery.collection.html.twig (line 32)
        {% endif %}        {% set attr = attr|merge({'data-allow-add': allow_add ? 1 : 0}) %}        {% set attr = attr|merge({'data-allow-remove': allow_delete ? 1 : 0 }) %}        {% set attr = attr|merge({'data-name-prefix': full_name}) %}        {{ block('form_widget') }}    {% endspaceless %}{% endblock collection_widget %}

I guess jquery.collection.html.twig should be updated to

{% block collection_widget %}
    {% apply spaceless %}
        {% if prototype is defined %}
            {% set attr = attr|merge({'data-prototype': form_row(prototype)}) %}
            {% set attr = attr|merge({'data-prototype-name': prototype.vars.name}) %}
        {% endif %}
        {% set attr = attr|merge({'data-allow-add': allow_add ? 1 : 0}) %}
        {% set attr = attr|merge({'data-allow-remove': allow_delete ? 1 : 0 }) %}
        {% set attr = attr|merge({'data-name-prefix': full_name}) %}
        {{ block('form_widget') }}
    {% endapply %} #Update this line
{% endblock collection_widget %}

picks44 avatar Jan 13 '20 10:01 picks44

Hello,

2.1.32 should be fixing the issue: https://github.com/ninsuo/symfony-collection/compare/2.1.32...master

Have a good day Alain

ninsuo avatar Jan 13 '20 10:01 ninsuo

Hi @ninsuo and thanks. Could you merge it to the master branch? Otherwise I'll have to specify this particular branch '2.1.32' to have the fix. Thanks!

picks44 avatar Jan 13 '20 12:01 picks44

Sure, having a look right now

ninsuo avatar Jan 13 '20 12:01 ninsuo

Could you please try using 2.1.33 ? Thanks

ninsuo avatar Jan 13 '20 12:01 ninsuo

For some reason I can't install it...

I'm declaring the package like this in my composer,json "ninsuo/symfony-collection": "^2.1",

and a composer update doesn't update to 2.1.33, and if I try to "force the version "ninsuo/symfony-collection": "2.1.33", I get the following error

 The requested package ninsuo/symfony-collection 2.1.33 exists as ninsuo/symfony-collection[2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.1.0, 2.1.1, 2.1.10, 2.1.11, 2.1.12, 2.1.13, 2.1.14, 2.1.15, 2.1.16, 2.1.17, 2.1.18, 2.1.19, 2.1.2, 2.1.20, 2.1.21, 2.1.22, 2
.1.23, 2.1.24, 2.1.25, 2.1.26, 2.1.27, 2.1.28, 2.1.29, 2.1.3, 2.1.30, 2.1.31, 2.1.32, 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8, 2.1.9, dev-master, dev-preparing-3.0] but these are rejected by your constraint.

picks44 avatar Jan 13 '20 13:01 picks44

And composer require ninsuo/symfony-collection 2.1.33 gives me

  [InvalidArgumentException]                                                     
  Could not find package ninsuo/symfony-collection in a version matching 2.1.33 

picks44 avatar Jan 14 '20 06:01 picks44

Hello,

Please try again.

Sorry for the inconvenience, it seems that my git hook stopped working on Packagist.

Cheers

ninsuo avatar Jan 14 '20 07:01 ninsuo

OK, looks like I finally manged to install it using the dev-master tag. Working like a charm again now, you can safely release 2.1.33 IMO :)

picks44 avatar Jan 14 '20 07:01 picks44

Hello, some news about this release ? I can't install it properly with npm update, same error

bastien70 avatar Jun 04 '20 12:06 bastien70