ninja icon indicating copy to clipboard operation
ninja copied to clipboard

Consider moving JPA-hibernate to separate module?

Open jjlauer opened this issue 10 years ago • 3 comments

While digging into Ninja's dependencies for my final assembly, I was trying to figure out why I had roughly 30MB of libs. After digging into ninja-core's dependencies, I discovered two main culprits -- ehcache and hibernate. I submitted a pull request recently to address ehcache in a way I think doesn't break anything.

The hibernate requirement seems to be optional -- I excluded those dependencies from my own project and my project runs fine since I use ebean rather than jpa-hibernate. Saved 10MB in dependencies out of 30MB.

What are your thoughts on pulling jpa into its own ninja-jpa sub-project? ninja-standalone could still technically add ninja-jpa back in as a dependency and then we add a new ninja-standalone-lite sub project that doesn't include it? Or if you feel like it's not a huge break for users, just remove it from ninja-standalone and point out they simply need to add ninja-jpa as a new requirement.

Thoughts?

jjlauer avatar Feb 20 '15 01:02 jjlauer

Sounds like #229.

gitblit avatar Feb 20 '15 13:02 gitblit

Ack. And it's still a good idea...

raphaelbauer avatar Feb 23 '15 20:02 raphaelbauer

:+1:

svenkubiak avatar Feb 24 '15 13:02 svenkubiak