OpenDeck icon indicating copy to clipboard operation
OpenDeck copied to clipboard
verified publisher icon ninjadev64

Deck Neo Support?

Open snek-the-great opened this issue 1 year ago • 1 comments

Hi, was wondering if we could get support for the Stream Deck Neo?

snek-the-great avatar Apr 18 '24 23:04 snek-the-great

Hi, looks like the device was only released a few hours ago!

To support the device, it will need to be supported by the elgato-streamdeck library that we use, so you'll have to bring it up with them.

nekename avatar Apr 19 '24 06:04 nekename

@ninjadev64 Hm is there any way we can inspire ourself from this support in Node : https://github.com/Julusian/node-elgato-stream-deck/issues/87 ? elgato-streamdeck lib is written in Python ?

EDIT : Sorry for the ping !

AkechiShiro avatar May 27 '24 22:05 AkechiShiro

Sorry, I'm not sure what you mean. elgato-streamdeck is a Rust library that I do not maintain, merely use, (I do not even own a Stream Deck,) and so any requests for changes to the library should be submitted to its maintainers (notably @TheJebForge).

nekename avatar May 28 '24 07:05 nekename

How can I use the rust library fork I'm working on @ninjadev64 in order to test if I can extend the support to Deck Neo ?

AkechiShiro avatar May 29 '24 19:05 AkechiShiro

@AkechiShiro I've added contributing instructions for OpenDeck to the README today, so follow those first, then change the path of the elgato-streamdeck library in src-tauri/Cargo.toml to point to your fork locally ;)

nekename avatar May 29 '24 19:05 nekename

The PR in elgato-streamdeck is in draft and I did test it the support works. @ninjadev64

AkechiShiro avatar Jun 07 '24 12:06 AkechiShiro

https://github.com/streamduck-org/elgato-streamdeck/pull/10#issuecomment-2154677103

AkechiShiro avatar Jun 07 '24 12:06 AkechiShiro

The PR in elgato-streamdeck is in draft and I did test it the support works. @ninjadev64

Cool

nekename avatar Jun 07 '24 17:06 nekename

The PR was merged in the lib, what is left so open deck also has support for Neo ? @ninjadev64

EDIT : A new release of the lib was made, version 0.7.0 with support for Neo.

I'm guessing bumping the Cargo.toml is enough for open deck to have the support.

AkechiShiro avatar Jun 16 '24 20:06 AkechiShiro

EDIT : A new release of the lib was made, version 0.7.0 with support for Neo.

I'm guessing bumping the Cargo.toml is enough for open deck to have the support.

Once Axias/Guillame's PR is merged, I'll bump the version of this crate so you can use your device in OpenDeck.

nekename avatar Jun 16 '24 21:06 nekename

I've created a PR if that can help, once you have merged the other PR, you can merge also this one https://github.com/ninjadev64/OpenDeck/pull/13

Thanks for your help !

AkechiShiro avatar Jun 16 '24 21:06 AkechiShiro

Merged, thanks!

nekename avatar Jun 17 '24 07:06 nekename

Thanks a lot too ! Can a new release be done for the Neo support to be packaged upstream @ninjadev64 ?

AkechiShiro avatar Jun 17 '24 20:06 AkechiShiro

I'll be publishing a new release soon, maybe this weekend.

nekename avatar Jun 17 '24 20:06 nekename

Hey @ninjadev64, just pinging again ! For the new release, if you have time this week-end !

AkechiShiro avatar Jun 23 '24 14:06 AkechiShiro

Hey @AkechiShiro

I had built a release earlier today, but had forgotten to publish it. Here you go!

https://github.com/ninjadev64/OpenDeck/releases/tag/v2.0.0-beta.9

nekename avatar Jun 23 '24 20:06 nekename