ningmingxiao comments

Results 304 comments of


                                            ningmingxiao

fix align the structs to decrease the memory footprint

> It does seem like a task for the Go compiler, not each project. [rustc is doing that](https://github.com/rust-lang/rust/issues/38550) already. [It was proposed in Go](https://github.com/golang/go/issues/53048), although it hadn't been accepted. >...

fix align the structs to decrease the memory footprint

do you have some tools to auto change these codes? find it fieldalignment at https://github.com/golang/tools

fix fifos.Stderr and fifos.Stdout may have parameters

> When does it have parameters? > > It is odd to see we parse that as a URL then discard the most of them. my another pr use file...

Are there two ways use btrfs?

@thaJeztah

docker exec can't get detail messages if runc init exited abnormally

> Seems like a Docker/containerd issue? runc outputs the error to stderr, it's up to Docker to format it as necessary. I suspect the issue is that our logs go...

docker exec can't get detail messages if runc init exited abnormally

if use the runc main branch ,docker exec will show error detail.

runc-shim-v2 hold lock cause cri can't delete container

I can't find out who hold the lock in containerd/runtime/v2/runc/task/service.go some similar issue https://github.com/containerd/containerd/issues/9446 @fuweid

fix opts maybe nill err

done thankyou @austinvazquez

fix can't start with -it flag

> Fixed by #1642 ? @ningmingxiao cc yes

internal/cri: log ctr's exit event on info level

sometimes I want to know when container is exited,but default log level is info will not print exited events some issue:https://github.com/containerd/containerd/issues/10025