erlang.mk icon indicating copy to clipboard operation
erlang.mk copied to clipboard

fix rebar dependency specification

Open galdor opened this issue 4 years ago • 2 comments

Rebar3 emits a warning for "raw" git dependency versions, and expects a tuple indicating what the version actually is (a branch, tag or ref).

This warning propagates to any software directly or indirectly using Gun.

This syntax also works with rebar2 (https://github.com/rebar/rebar/blob/master/src/rebar_deps.erl#L608).

galdor avatar Aug 11 '20 15:08 galdor

There's errors https://buildkite.com/ninenines/erlang-dot-mk-prs/builds/571#f82429ad-13c2-4949-b0ca-24d31d05f43e/55-739

I can help tomorrow.

essen avatar Aug 11 '20 16:08 essen

That's fine for commits but will this work fine for tags and branches too? Is there some expectations around differentiating ref/branch/tag in the rebar.config?

essen avatar May 12 '23 12:05 essen