cowlib

cowlib copied to clipboard

Upgrade tokens are case sensitive

1

Based on a recent discussion on httpbis. Confusion around websocket/WebSocket, it sounds like Cowboy should accept both for that particular case.

essen

Revisit UTF-8 validation

2

The code in https://github.com/ninenines/cowlib/blob/cc04201c1d0e1d5603cd1cde037ab729b192634c/src/cow_ws.erl#L581-L588 was written a decade ago. The VM has changed a lot. The JSON PR in OTP has a different way of doing this that may be...

essen

When parsing we should return a headers tuple that doesn't contain PRIORITY information, even if it was given. When building we should not include PRIORITY. This is already the case...

essen

To be done later on. Adds a date type: https://httpwg.org/http-extensions/draft-ietf-httpbis-sfbis.html

essen

mjs text/javascript mimetype

3

Is it possible to update cow_mimetypes.erl to include JavaScript modules mimetype? It is included here: https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types ```erlang all_ext() -> {, , []}; web_ext() -> {, , []}; ```

benbro

Export types used in the exported cow_http2:frame() type

1

With these types exported, a frame() can be decomposed and all parts can be typed using exported types.

zuiderkwast

An HTTP/2 204 (No Content) response containing a Content-Length header is considered invalid

5

As the title suggests, I think the library is too strict in regards to 204 (No Content) responses that contain a `Content-Length` response header, in the context of HTTP/2. While...

iqltd

Will it be better to replace zlib:inflate/2 with [zlib:safeinflate/2 ](https://www.erlang.org/doc/apps/erts/zlib.html#safeInflate/2) to prevent zlib-bomb as mentioned [here](https://github.com/ninenines/cowboy/issues/946#issuecomment-348746981)? https://github.com/ninenines/cowlib/blob/master/src/cow_ws.erl#L546 and few other places. Is there a benchmark for cowboy WebScokets with and...

benbro