netbox-client-ruby icon indicating copy to clipboard operation
netbox-client-ruby copied to clipboard

Published 20 hours ago • verified publisher icon ninech

fatal : Aucun nom trouvé, impossible de décrire quoi que ce soit.

Open n-rodriguez opened this issue 1 year ago • 2 comments

I got this error message every time I run a bundle rspec command (or whatever command)

This comes from this commit https://github.com/ninech/netbox-client-ruby/commit/f5c97a8621adaef5cd2e79ef0e19cbd7a6d57348#r148222395 which is considered as a bad practice.

IMHO https://github.com/ninech/netbox-client-ruby/commit/f5c97a8621adaef5cd2e79ef0e19cbd7a6d57348#r148222395 should be reverted.

Thank you!

n-rodriguez avatar Oct 22 '24 15:10 n-rodriguez

I don't understand. Why should it be bad practice?

thde avatar Oct 23 '24 11:10 thde

I don't understand. Why should it be bad practice?

Because depending on the platform git is not always available.

It's commonly admitted to use git to list gem files, but more and more Rubyist tend to change this to use pure Ruby to avoid relying on git presence. For example : https://github.com/fxn/zeitwerk/blob/main/zeitwerk.gemspec#L19

n-rodriguez avatar Oct 23 '24 12:10 n-rodriguez