Nina Miolane
Nina Miolane
`ElasticMetric` does not have log, exp and geodesics, which should be added. Florent-Michel should have code for the geodesic.
'DiscreteCurves' object has no attribute 'random_uniform'
DiscreteCurves should also inherit from Landmarks and have a fixed number of sampling points. This would be more consistent with the code base, and avoid math.inf in the dimensions of...
- [x] SRVMetric should inherit from ElasticCurve - [x] srv_transform and srv_transform inverse should overwrite f_transform and f_transform_inverse
- [x] f_transform_inverse should be unit-tested
- [x] the API of the discrete curves module should be cleaned up: so far, it alternates between calling curves `curve_a, curve_b` and `point_a, point_b` where the latter comes from...
PR #1632 addresses the API issue.
Copy-pasting here a comment from PR #1632 @alebrigant Re name: `SRVShapeBundle`: I wonder if we should put the name of the group inducing the quotient in the name of the...
Nice! 🙌 thanks for re-opening this PR with only the SL files. A few comments: - Could you make sure that the tests pass before moving the PR from "draft"...
@lpereira95 any update on this?