Nimish Medatwal

@zulipbot abandon

@zulipbot claim

@timabbott > What CSS generates the hover effect that you're overriding here? This part of code in `dark_theme.css` generates the hover effect (line 29). ```css %dark-theme { & a:hover {...

> I'm not sure what exactly is off about it. Including one-to-one before/after comparisons would be helpful; see @karlstolley 's PRs for some examples of how to do that. Sure...

@karlstolley I've changed a lot of things in this pr, can you please give it another review?

@karlstolley I've changed `copy_to_clipboard_svg.hbs` so that it now uses `` tag instead like you suggested. One more thing about copy button that bugs me is that when you view a...

@karlstolley that's weird I checked everything before pushing the code. Edit: I checked again and it looks fine in my dev env.  

One bug I noticed while testing is that if a user accidently clicks and drags the copy icon then upon releasing the icon will get uploaded as an .svg file...

> I'm still puzzled by the copy-paste job here. Would it be possible to just reference the `copy_to_clipboard.svg` file here in an `` tag? There might be side-effects with that,...

@karlstolley I think I've incorporated all the changes that you suggested, it is working perfectly while testing (change of icon's color on hover is also working). I've also deleted `copy_xxx.hbs`...