qr-scanner icon indicating copy to clipboard operation
qr-scanner copied to clipboard

Published 20 hours ago • verified publisher icon nimiq

Don't restart video stream when turning flash off

Open daniel-kun opened this issue 2 years ago • 4 comments

This reduces the "flickering" when turning the flash off.

The comment in the code that I removed indicates that the video stream was explicitly restarted, because a sentence in MDN indicates that this might be necessary.

However, I have tested this with multiple smartphones and found that it is not necessary and that you can toggle off the flash while the stream is active.

Tested with:

  • Samsung A70 (SM-A705FN)
  • Motorola g200
  • Nokia 8.1
  • Nokia 5.3

(iPhones never have flash available, Apple seems to think it is a good idea to keep their users safe from such useful features.)

daniel-kun avatar Oct 21 '22 16:10 daniel-kun

Hey there, what's the status with this pull request? I just looked for this issue and this looks like a really nice change. Any way I can support you with merging this?

moritz157 avatar Mar 07 '23 14:03 moritz157

I might also add, that I cannot turn the flash off at all when testing on my OnePlus 9 Pro in Chrome.

moritz157 avatar Mar 07 '23 14:03 moritz157

if anybody needs this then use my this as dependency "qr-scanner": "git+https://github.com/laszlo1337/qr-scanner.git"

laszlo1337 avatar Dec 12 '23 14:12 laszlo1337

I would also really appreciate it if this could be merged so that there is no need to restart the stream.

unalkyl avatar Mar 20 '24 15:03 unalkyl