core-rs-albatross icon indicating copy to clipboard operation
core-rs-albatross copied to clipboard

Fix ordering of the diff queue

Open ii-cruz opened this issue 5 months ago • 0 comments

What's in this pull request?

The introduction of the diffs needed flag made it so that the blocks are returned out of order. This does not seem to be a bug, however, it is a strange behavior. This PR restores the original diff queue order by appending to the futures ordered diffs despite us not needing diffs. These futures will resolve immediately with no None diff attached to the block.

I refactored the poll function and the function arguments a bit as well.

Pull request checklist

  • [x] All tests pass. The project builds and runs.
  • [x] I have resolved any merge conflicts.
  • [x] I have resolved all clippy and rustfmt warnings.

ii-cruz avatar Aug 29 '24 16:08 ii-cruz