core-rs-albatross
core-rs-albatross copied to clipboard
Refactor block verification
- Refactor block verification functions in
blockchain
such that they can be split by its small verification functions that only receive as argument the required information. - Add tests at the primitives
block
crate to stimulate the block verification functionality.
Pull request checklist
- [X] All tests pass. Demo project builds and runs.
- [X] I have resolved any merge conflicts.
Codecov Report
Base: 65.00% // Head: 65.01% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
97fbfad
) compared to base (6a677a2
). Patch coverage: 80.30% of modified lines in pull request are covered.
:exclamation: Current head 97fbfad differs from pull request most recent head 75a5bb8. Consider uploading reports for the commit 75a5bb8 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## albatross #1125 +/- ##
===========================================
Coverage 65.00% 65.01%
===========================================
Files 368 368
Lines 45151 44967 -184
===========================================
- Hits 29351 29235 -116
+ Misses 15800 15732 -68
Flag | Coverage Δ | |
---|---|---|
unittests | 65.01% <80.30%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
blockchain/src/abstract_blockchain.rs | 89.06% <0.00%> (-6.36%) |
:arrow_down: |
blockchain/src/error.rs | 50.00% <ø> (+2.63%) |
:arrow_up: |
light-blockchain/src/push.rs | 0.00% <0.00%> (ø) |
|
primitives/block/src/lib.rs | 100.00% <ø> (ø) |
|
validator/src/tendermint.rs | 0.00% <0.00%> (ø) |
|
primitives/block/src/micro_block.rs | 81.57% <78.29%> (+8.85%) |
:arrow_up: |
primitives/block/src/macro_block.rs | 87.02% <79.03%> (+8.67%) |
:arrow_up: |
consensus/src/sync/history/cluster.rs | 87.19% <84.21%> (-0.56%) |
:arrow_down: |
primitives/block/src/block.rs | 61.75% <86.15%> (+7.35%) |
:arrow_up: |
blockchain/src/blockchain/verify.rs | 62.93% <93.10%> (-4.77%) |
:arrow_down: |
... and 23 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.