core-js icon indicating copy to clipboard operation
core-js copied to clipboard

Unable to build core-js using Node v22.1.0

Open joeleol opened this issue 1 year ago • 2 comments

New issue checklist

General information

  • Library version(s): v1.6.2

Bug report

While building core-js with Node v22.1.0 the process is terminated due to various errors.

I reverted to Node v20.13.1 and could build again, so I guess the issue came in a version between these two.

Expected behavior

core-js to be built successfully.

Actual behavior

Process is terminated due to various errors.

Steps to reproduce

Follow the Quickstart guide on a machine with Node v22.1.0 installed.

Crash log? Screenshots? Videos? Sample project?

Please see attached log.

joeleol avatar May 15 '24 11:05 joeleol

The log... core-js error.pdf

joeleol avatar May 15 '24 11:05 joeleol

From your log I see that node-lmdb fails to build with Node 22's gyp. I don't see any mention of Node 22 in any of node-lmdb's issues, PRs or recent commits.

Seems like @jeffesquivels can have a look again, he already added support for Node 20 to node-lmdb.

sisou avatar May 15 '24 11:05 sisou

Hi @joeleol,

Can you please try again using the latest commit on master and let me know if it works for you?

Thanks,

jeffesquivels avatar May 30 '24 22:05 jeffesquivels

Hi @jeffesquivels

Compiles now with Node v22 - thanks!

joeleol avatar May 31 '24 07:05 joeleol

@joeleol Nice. You're welcome!

jeffesquivels avatar May 31 '24 17:05 jeffesquivels