BasePoolMiner ignore config using ws

[Azard]

New issue checklist

• [x] I have read all of the README
• [x] I have searched existing issues and this is not a duplicate.

General information

• Library version(s): latest
• Reproducible in the testnet? (Yes/No): Yes

Bug report

Expected behavior

connect to ws://poolServer:port

Actual behavior

failed

Crash log? Screenshots? Videos? Sample project?

https://github.com/nimiq-network/core/blob/master/src/main/generic/miner/BasePoolMiner.js#L64

this line ignore config file protocol, force using wss

[riptl]

The config file assumes that the pool is running wss and has no option to switch to ws. You can only set the host and port, of the pool, not the protocol.

    poolMining: {
        enabled: false,
        host: null,
        port: -1,
        mode: 'smart',
        deviceData: null
    },

[riptl]

@Azard I added a config parameter to enable mining on ws:// pools. Run git clone https://github.com/terorie/nimiq-core -b custom-pool-protocol to get my patched source code with support for ws:// pools.

Then, in your config, set something like this:

    // Configure pool mining on this node.
    poolMining: {
        enabled: "yes",
        protocol: "ws",
        //host: "pool.domain",
        //port: 8444,
    },

[Azard]

@terorie Thanks, I change it too, but I hope this patch could merge into Nimiq core

[jeffesquivels]

Closing stalled issue.

Since all efforts are now geared toward albatross, it's unlikely this would be implemented.