rails-templates icon indicating copy to clipboard operation
rails-templates copied to clipboard

[gh-261] Use Phrase/phrase instead of PhraseApp/phraseapp/phrase_app everywhere

Open junan opened this issue 3 years ago • 5 comments

  • Close #261

What happened 👀

Provide a description of the changes this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.

Insight 📝

Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.

Proof Of Work 📹

Show us the implementation: screenshots, GIFs, etc.

junan avatar Aug 22 '22 11:08 junan

@junan the overall changes look good to me! :) Let me know if you need any help to finish this work 🙌

malparty avatar Aug 29 '22 04:08 malparty

@junan the overall changes look good to me! :) Let me know if you need any help to finish this work 🙌

@malparty I found that in the develop branch it does not create the phraseapp.yml even you select the phraseapp addons. How did it work in the rails application project you are working? or it does not have the phraseapp yet?

junan avatar Sep 15 '22 08:09 junan

@junan I think it's when you run the phrase command for the first time phrase init in your project. Maybe you can try that CLI and add the needed files directly in the template add-on? :) Thanks 🙌

malparty avatar Oct 04 '22 04:10 malparty

@malparty Just to update you, I have not able to work on it after the last commit. So you might assign it to someone else to continue

junan avatar Oct 19 '22 11:10 junan

@junan ok, thanks for your work so far! :) I'll try to finish it ;-)

malparty avatar Oct 20 '22 03:10 malparty