rails-templates
rails-templates copied to clipboard
[#331] Add an option to choose the RSpec otherwise skip the Rspec configuration
Issue
#331
What happened
Allow user to choose Rspec
test framework, if N
is chosen, stick with Rails default test framework.
Insight
Make rspec Optional.
Proof Of Work
@malparty Hi, I made changes to install RSpec as a testing library conditionally. Am I missing any RSpec dependencies that need to be conditionally loaded along with RSpec?
@przbadu hi, Thanks for your contribution :) I will test it tomorrow and also discuss it with some teammates so they can support me in checking that more in details 🙌
@przbadu there are some concerns I am not sure how to resolve at the moment:
- Readme.md: The test section provide rspec-specific instructions. Should we just add an indication that this section only applies when the
rspec
add-on has been selected? 🤔 -
.rubocop.yml
: When the rspec add-on is not selected, we should remove line 3 because it requires a gem that is not installed (rubocop-rspec). Same for the last rules at the end of the file.
Let me know if you have an idea to handle them 🙌
PS: We have some teammates off this week and next week so the team supporting our Rail Template might be slower than usual to review/merge PR, sorry for the inconvenience~
Hey, sorry, I was off for few days. Will check it.
@przbadu No worries, take you time, we were also quite busy this past weeks and should be back on track by end of next week to follow up with all your PRs ;-)
@przbadu just to let you know we have planned a new release for the end of the month. Your previously merged contributions will be included. This PR might not be, unless we can move forward with the feedback ;-) We will try to have monthly releases to keep the project up to date. Let me know if I can support you on anything, Thanks,
Closing as long time without activity.