pytorch_influence_functions icon indicating copy to clipboard operation
pytorch_influence_functions copied to clipboard

Default Configuration GPU Setting in the README

Open ZaydH opened this issue 5 years ago • 1 comments

In the README, it states:

gpu: Default = -1, -1 for calculation on the CPU otherwise GPU id

If I am understanding the meaning of "default" here, you are referring to the function get_default_config. Looking at that function's definition, it looks like the default value appears to be 0.

Assuming my understanding is correct and there is an issue, I am happy to submit a pull request to either update get_default_config to match the README or vice version -- whichever is correct. If I misunderstood the meaning of "default" please feel free to close.

ZaydH avatar Jan 11 '21 16:01 ZaydH

After submitting this case, I noticed that scale and damp have different values listed as default than in get_default_config. Both are None in the code but in the README it says:

damp: Default = 0.01, damping factor during s_test calculation. scale: Default = 25, scaling factor during s_test calculation.

That makes me think more that "default" does not refer to get_default_config.

ZaydH avatar Jan 11 '21 16:01 ZaydH