packages icon indicating copy to clipboard operation
packages copied to clipboard

sandia openshmem PR

Open ct-clmsn opened this issue 2 years ago • 3 comments

this PR adds support for openshmem to nim

ct-clmsn avatar Apr 22 '22 02:04 ct-clmsn

Hello, @ct-clmsn This PR doesn't seem to contain any commit.

ringabout avatar Apr 22 '22 04:04 ringabout

@xflywind apologies - will send fix very soon.

ct-clmsn avatar Apr 30 '22 12:04 ct-clmsn

ping

ringabout avatar Jul 08 '22 03:07 ringabout

It has been almost a year, @ct-clmsn everything alright?

PhilippMDoerner avatar Feb 17 '23 18:02 PhilippMDoerner

@PhilippMDoerner all is well, what is the block on this PR? I think the 'no commit' comment threw me off.

ct-clmsn avatar Feb 19 '23 13:02 ct-clmsn

Really? where are your changes?

image

ringabout avatar Feb 19 '23 13:02 ringabout

8 commits, no files changed. I haven't had this issue before. @ringabout could you check the commits tab? It shows which files have been changed and where the files have been changed. I'm not sure what the issue is on my end, the commits make the local file consistent with the remote file.

In the commit log, you'll see file modfications were added around 'https://github.com/ct-clmsn/nim-sos/' - that's the git repository for nim openshmem source which means the information was merged or exists in the modified file. So, I'm not sure what happened here.

I can close this PR without a merge, review the current state of the main version, and resubmit as a new PR if necessary. Suspect there is a consistency issue with my git repository.

ct-clmsn avatar Feb 19 '23 13:02 ct-clmsn

PR closed made OBE (over taken by events) due to other PRs

ct-clmsn avatar Feb 19 '23 15:02 ct-clmsn