nimforum icon indicating copy to clipboard operation
nimforum copied to clipboard

Feature/#331 formatting of codeblock comments in search breaks

Open PhilippMDoerner opened this issue 2 years ago • 1 comments

Fixes #331

Fixes overall 2 issues:

  1. ## , # and the like often get rendered into headlines under the right circumstances. By replacing them with \# (which most of the time get rendered to # instead of \# ) you can prevent this from the get-go

  2. Search-hits sometimes get incorrectly boldened. As in, you get rendered **blabla**NoWhitespaceHere, which will lead to the stars being rendered instead of them turning bold. By enforcing in the SQL that "post-snippet" it'll add ** instead of just stars, you can prevent this problem from the start.

  3. also takes care of some HTML rendering problems: Broken example: image

  • It renders ** instead of making it bold -Whitespacing is generally broken
  • ## [ ( )*] r should actually contain this HTML string: ## [<p1> (<p2> <p1>)*]

Now with the fixes applied: image

PhilippMDoerner avatar Jan 26 '23 14:01 PhilippMDoerner

As discussed in #331, please consider removing text formatting altogether. This change somewhat fixes code rendering, but breaks normal markdown rendering.

jyapayne avatar Feb 01 '23 15:02 jyapayne