nimble icon indicating copy to clipboard operation
nimble copied to clipboard

Feat: Add package name to no tagged releases warning

Open MorganaFuture opened this issue 4 months ago • 5 comments

  • Add extractPackageName() to extract package names from URL
  • Update warning messages to show specific package name
  • Add unit tests for new functionality

Link: Issues 1432

MorganaFuture avatar Aug 12 '25 10:08 MorganaFuture

This approach is quite fragile i.e. https://github.com/status-im/nim-json-serialization/

jmgomez avatar Aug 12 '25 10:08 jmgomez

If the canonical name is not available yet, I think it's fine to print the url / whatever was given to requires in this case

arnetheduck avatar Aug 12 '25 11:08 arnetheduck

The name is available though as the package is supposed to be cloned already

Edit: you are right. Looked at a bad spot in the code. The right thing to do is to print the url

jmgomez avatar Aug 12 '25 11:08 jmgomez

Hi @jmgomez @arnetheduck I rewrote the PR to show the URL instead of the name. I also used nph for formatting, as I understand it, it is not mandatory in the project?) Is it necessary to revert everything back?

MorganaFuture avatar Aug 26 '25 07:08 MorganaFuture

Is it necessary to revert everything back?

IMHO, yes, as now the diff contains many random changes and worse, the original formatting seems better too.

Araq avatar Aug 26 '25 12:08 Araq