Nim icon indicating copy to clipboard operation
Nim copied to clipboard

Published 20 hours ago • verified publisher icon nim-lang

move dollars out of system

Open ringabout opened this issue 1 year ago • 1 comments

  • the compiler keeps bootstrapping with -d:nimPreviewSlimSystem
  • the std/dollars uses new float algorithm when -d:nimPreviewSlimSystem is enabled, otherwise you can still switch them on/off by nimPreviewFloatRoundtrip

ringabout avatar Aug 09 '22 11:08 ringabout

ref https://github.com/nim-lang/Nim/pull/19388 ref https://github.com/nim-lang/RFCs/issues/437

ringabout avatar Aug 10 '22 02:08 ringabout

Was this discussed previously? Doesn't echo need $?

Edit: Apparently it was discussed in #19388 but just for floats. dollars has way more than that, plus addFloat is still included in system here, so compilation time isn't saved. I think this is an overly dramatic thing to do just to enable roundtrip float-string conversion. If it was for the sake of separating $, then I would understand it, but $ is deeply integrated in a lot of Nim code so it's not going to be easy to just casually do.

metagn avatar Aug 10 '22 23:08 metagn