Nim icon indicating copy to clipboard operation
Nim copied to clipboard

Published 20 hours ago • verified publisher icon nim-lang

fixes #19967; reset does not work on set [backport: 1.2]

Open ringabout opened this issue 2 years ago • 2 comments

fixes https://github.com/nim-lang/Nim/issues/19967

  • [x] add a testcase for emums

ringabout avatar Jul 03 '22 15:07 ringabout

followed the advice from https://github.com/nim-lang/Nim/pull/19968#discussion_r914471750

ringabout avatar Jul 31 '22 09:07 ringabout

It is ready for review.

ringabout avatar Aug 06 '22 11:08 ringabout

Is this a backport of a change that has already been merged into devel? If so, can you give me a link to the relevant PR? Then I can review and merge.

Varriount avatar Aug 21 '22 21:08 Varriount

No, it is a PR for the devel branch. Backport annotation is a convention which means the PR should be backported to 1.2 and 1.6 branches.

ringabout avatar Aug 22 '22 00:08 ringabout

Thanks for your hard work on this PR! The lines below are statistics of the Nim compiler built from e8556b45f58b3b231c3720189bad9a4eeb6ca51f

Hint: mm: orc; threads: on; opt: speed; options: -d:release 163641 lines; 17.409s; 841.379MiB peakmem

github-actions[bot] avatar Aug 23 '22 16:08 github-actions[bot]