Undeprecate isvalidfilename

[juancarlospaco]

• Remove deprecated isValidFilename.

[juancarlospaco]

Any news with this one, is there any critical blocker ?. 🙂

[Araq]

Instead undeprecate it. It does what its documentation says? What's the issue again, that people use things without reading the docs? What kind of criterion is that?

[Varriount]

@Araq The problem is that a "valid" filename depends on both the operating system and file system being used - it's a fundamentally flawed approach. It's better to just... attempt to create a file with a given filename.

See my comment here, from previous discussions regarding this function.

[Araq]

The problem is that a "valid" filename depends on both the operating system and file system being used - it's a fundamentally flawed approach.

I remember the discussion and your point is valid but it's useful enough in practice.

[github-actions[bot]]

Thanks for your hard work on this PR! The lines below are statistics of the Nim compiler built from 1e635bb539839cab8b7552df9ca0a073dfa523fa

Hint: mm: orc; threads: on; opt: speed; options: -d:release 164356 lines; 15.295s; 665.059MiB peakmem