Nim enable strictEffects for tests

enable strictEffects for tests

Open ringabout opened this issue 2 years ago • 3 comments

let's see what it breaks.

Jan 13 '22 08:01 ringabout

Tests need to be updated but important packages seem to work, so please proceed.

Jan 16 '22 10:01 Araq

Here is the progress of fixing important packages:

https://github.com/nitely/nim-regex/pull/110

Jan 20 '22 07:01 ringabout

made a PR for arraymancer: https://github.com/mratsim/Arraymancer/pull/549

Jan 20 '22 14:01 ringabout

issues tracking

[x] nimgen, nimterop, prologue require nim-regex to release a new tag https://github.com/nitely/nim-regex/issues/116
[x] nimquery nimquery\nimquery.nim(749, 42) Error: $demand can raise an unlisted exception: Exception https://github.com/GULPF/nimquery/pull/19
[x] telebot asyncmacro.nim(212, 31) Error: 'callbackIter' is not GC-safe as it calls 'unmarshal' https://github.com/ba0f3/telebot.nim/pull/79
[x] weave https://github.com/mratsim/weave/pull/184
[x] numericalnim /home/runner/.nimble/pkgs/cdt-#head/cdt/minmax.nim(123, 11) Hint: 'minValueBy' calls routine via hidden pointer indirection https://github.com/HugoGranstrom/cdt/pull/1 https://github.com/SciNim/numericalnim/pull/31
[x] parsetoml /home/runner/work/Nim/Nim/pkgstemp/parsetoml/src/parsetoml.nim(1742, 6) Hint: '==' called by '==' https://github.com/NimParsers/parsetoml/pull/58
[x] fusion/tests/tmatching fusion/src/fusion/matching.nim(558, 6) Error: '$' can have side effects https://github.com/nim-lang/Nim/pull/19380/commits/5842184712c8ce9ab4f2b279e83f6f0a33aad116
[ ] ggplotnim 'addQuoted' calls .sideEffect '$'
[x] yaml Error: repr(e.parent) can raise an unlisted exception: Exception https://github.com/flyx/NimYAML/pull/125
[x] glob https://github.com/haltcase/glob/pull/58
[x] docopt Error: 'docopt' is not GC-safe as it calls 'docopt_exc' https://github.com/docopt/docopt.nim/pull/56

See also https://github.com/nim-lang/Nim/issues/19303

Oct 06 '22 08:10 ringabout

Thanks for your hard work on this PR! The lines below are statistics of the Nim compiler built from 1e15f975b83951006d69e6e39836aa2d525028c4

Hint: mm: orc; opt: speed; options: -d:release 162749 lines; 8.317s; 614.703MiB peakmem