path2d-polyfill icon indicating copy to clipboard operation
path2d-polyfill copied to clipboard

[doc] attach bump node support detail to changelog or release note for version 2.1.1

Open zhaojjiang opened this issue 1 year ago • 4 comments
trafficstars

my environment:

  • node: 16
  • pdfjs-dist: 3.6.172 (the latest version compatible with node 16 engine)

path2d-polyfill semver in pdfjs is: ^2.0.1, so the latest version 2.1.1 is matched, and cannot installed correctly

Although I think this is a dependency issue with pdfjs, I still hope to solve it from path2d-polyfill, because pdfjs@~3.6.172 is a history version, I am not sure if they will fix this.

zhaojjiang avatar Jul 05 '24 09:07 zhaojjiang

what is the issue you're having?

and do you have a suggestion for a fix?

nilzona avatar Jul 07 '24 22:07 nilzona

what is the issue you're having?

i want to install pdfjs-dist with node version 16, and i found [email protected] is the latest version which support node 16. but recently i found [email protected] broke this

and do you have a suggestion for a fix?

i am not sure if node 18 is necessary for 2.1.1, if it is necessary or it is hard to drop node version limit, i hope path2d-polyfill can attach info (bump node version support from any/16 to 18) to changelog / release note, so we can easily to found which version changed support, and try to manually downgrade or something else.

in my case, i viewed commits to find the change, and used yarn and resolution to use specific version 2.0.1

zhaojjiang avatar Jul 08 '24 00:07 zhaojjiang

I haven't tested this myself yet ... but the dependency I see from pdf-dist here is path2d

path2d requires node >= 6 .... defined here

Do you get errors when you install? or how is your issue exposed?

nilzona avatar Jul 11 '24 06:07 nilzona

I haven't tested this myself yet ... but the dependency I see from pdf-dist here is path2d

here for [email protected], old version still nees polyfill

path2d requires node >= 6 .... defined here

here for pollfill 2.1.1 engine line

Do you get errors when you install? or how is your issue exposed?

yarn add pdfjs-dist@~3.6.172 with node version 16

zhaojjiang avatar Jul 11 '24 07:07 zhaojjiang

specific pdfjs version is outdated, I shouldn't ask you for extra work on this. thanks.

zhaojjiang avatar Mar 02 '25 04:03 zhaojjiang