Back button and new interface issue

Open KekSantiago opened this issue 3 years ago • 1 comments

Page on which it happened

Password page where you see Pwd, Account, Email, etc... Problem: Naturally hitting Back will send you to the login screen, when it could simply take you back to the passwords list.

Btw, I don't see the value of opening an entry's values on another screen while taking you away from the list... it makes things slower. Sometimes you need to browse through entries and I can't even use the browser's back as detailed above... You basically created a lot more need for mouse movement towards the page's back button and then towards the new entries.....

Steps to reproduce

Be anywhere.
Hit browser Back button.
It will take you the login page.

Expected behaviour

Tell us what should happen: You should make it so that the browser back button takes you back to the list of entries and NOT to the login screen.

Actual behaviour

Tell us what happens instead

Server configuration

Operating system: Linux teampass-vm 5.4.0-113-generic #127-Ubuntu SMP Wed May 18 14:30:56 UTC 2022 x86_64

Web server: Apache/2.4.41 (Ubuntu)

Database: 8.0.29-0ubuntu0.20.04.3

PHP version: 8.0.19

Teampass version: 3.0.0.18

Teampass configuration file:

'max_latest_items' => '10',
'enable_favourites' => '1',
'show_last_items' => '1',
'enable_pf_feature' => '1',
'log_connections' => '1',
'log_accessed' => '1',
'time_format' => 'H:i:s',
'date_format' => 'd/m/Y',
'duplicate_folder' => '0',
'item_duplicate_in_same_folder' => '0',
'duplicate_item' => '0',
'number_of_used_pw' => '5',
'manager_edit' => '1',
'cpassman_dir' => '/var/www/html/teampass',
'cpassman_url' => 'http://<anonym_url>/teampass
'favicon' => 'http://<anonym_url>/teampass/favicon.ico',
'path_to_upload_folder' => '/var/www/html/teampass/upload',
'url_to_upload_folder' => 'http://<anonym_url>/teampass/upload',
'path_to_files_folder' => '/var/www/html/teampass/files',
'url_to_files_folder' => 'http://<anonym_url>/teampass/files',
'activate_expiration' => '0',
'pw_life_duration' => '0',
'maintenance_mode' => '0',
'enable_sts' => '0',
'encryptClientServer' => '1',
'cpassman_version' => '2.1.27',
'ldap_mode' => '0',
'ldap_type' => '0',
'ldap_suffix' => '0',
'ldap_domain_dn' => '0',
'ldap_domain_controler' => '0',
'ldap_user_attribute' => '0',
'ldap_ssl' => '0',
'ldap_tls' => '0',
'ldap_elusers' => '0',
'ldap_search_base' => '0',
'ldap_port' => '389',
'richtext' => '0',
'allow_print' => '1',
'roles_allowed_to_print' => '1',
'show_description' => '1',
'anyone_can_modify' => '0',
'anyone_can_modify_bydefault' => '0',
'nb_bad_authentication' => '0',
'utf8_enabled' => '1',
'restricted_to' => '0',
'restricted_to_roles' => '0',
'enable_send_email_on_user_login' => '0',
'enable_user_can_create_folders' => '0',
'insert_manual_entry_item_history' => '0',
'enable_kb' => '0',
'enable_email_notification_on_item_shown' => '0',
'enable_email_notification_on_user_pw_change' => '0',
'custom_logo' => 'https://spheragroup.com/wp-content/themes/spheragroup/assets/images/[email protected]',
'custom_login_text' => '',
'default_language' => 'english',
'send_stats' => '0',
'send_statistics_items' => '',
'send_stats_time' => '1545492207',
'get_tp_info' => '0',
'send_mail_on_user_login' => '0',
'nb_items_by_query' => 'auto',
'enable_delete_after_consultation' => '0',
'enable_personal_saltkey_cookie' => '0',
'personal_saltkey_cookie_duration' => '31',
'email_smtp_server' => '<removed>'
'email_smtp_auth' => '1',
'email_auth_username' => '<removed>'
'email_auth_pwd' => '<removed>'
'email_port' => '465',
'email_security' => 'ssl',
'email_server_url' => '',
'email_from' => '<removed>'
'email_from' => '<removed>'
'pwd_maximum_length' => '40',
'google_authentication' => '0',
'delay_item_edition' => '0',
'allow_import' => '0',
'proxy_ip' => '',
'proxy_port' => '',
'upload_maxfilesize' => '10mb',
'upload_docext' => 'doc,docx,dotx,xls,xlsx,xltx,rtf,csv,txt,pdf,ppt,pptx,pot,dotx,xltx',
'upload_imagesext' => 'jpg,jpeg,gif,png',
'upload_pkgext' => '7z,rar,tar,zip',
'upload_otherext' => 'sql,xml',
'upload_imageresize_options' => '1',
'upload_imageresize_width' => '800',
'upload_imageresize_height' => '600',
'upload_imageresize_quality' => '90',
'use_md5_password_as_salt' => '0',
'ga_website_name' => 'TeamPass for ChangeMe',
'api' => '0',
'subfolder_rights_as_parent' => '1',
'show_only_accessible_folders' => '0',
'enable_suggestion' => '0',
'otv_expiration_period' => '7',
'default_session_expiration_time' => '60',
'duo' => '0',
'enable_server_password_change' => '0',
'ldap_object_class' => '0',
'bck_script_path' => '/var/www/html/teampass/backups',
'bck_script_filename' => 'bck_teampass',
'syslog_enable' => '0',
'syslog_host' => 'localhost',
'syslog_port' => '514',
'manager_move_item' => '0',
'create_item_without_password' => '0',
'otv_is_enabled' => '0',
'agses_authentication_enabled' => '0',
'item_extra_fields' => '0',
'saltkey_ante_2127' => 'none',
'migration_to_2127' => 'done',
'files_with_defuse' => 'done',
'timezone' => 'Europe/Bucharest',
'enable_attachment_encryption' => '1',
'personal_saltkey_security_level' => '50',
'ldap_new_user_is_administrated_by' => '0',
'disable_show_forgot_pwd_link' => '0',
'offline_key_level' => '0',
'enable_http_request_login' => '0',
'ldap_and_local_authentication' => '0',
'secure_display_image' => '1',
'upload_zero_byte_file' => '0',
'upload_all_extensions_file' => '0',
'bck_script_passkey' => '<removed>'
'admin_2fa_required' => '1',
'teampass_version' => '2.1.27',
);

Updated from an older Teampass or fresh install:

Client configuration

Browser: -

Operating system: - bits

Logs

Web server error log

Undefined variable $post_data - /var/www/html/teampass/sources/main.queries.php (478)

Teampass 10 last system errors

 * 20/09/2021 15:57:19 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('ionut.dancescu', 'Ionut', 'DANCESCU', '$2y$13$605f05200e4f8d4f8cb84Od5Z50vOui9XIGUeKFdR/LfsGMZtmzUC', '[email protected]', '0', '0', '0', '1', 'english', '2;', '', '2;5;7;15;25;31;13;20;14;8;37;40;19;9;1;10;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php * 21/01/2019 18:39:38 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('dragos.costache', 'Dragos', 'Costache', '$2y$13$70e8749d564f9f49ad67euxrq1.BdZ8wZMj6NPs7siaA3tzXDr2eC', '[email protected]', '0', '1', '0', '0', 'english', '1;', '', '2;1;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php * 21/01/2019 18:38:04 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('andrei.filip', 'Andrei', 'Filip', '$2y$13$21d74c002b7002411d4faeAjKbpHglg5MEc38Th898alze1Vf.tVG', '[email protected]', '0', '0', '0', '0', 'english', '1;', '', '2;1;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php * 21/01/2019 18:36:29 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('teohare.popa', 'Teohare', 'Popa', '$2y$13$66cb4f8ad26451b7a0022eQwhnNvbfWqRnMH3OnKtSo6q9BmOlZbm', '[email protected]', '0', '0', '0', '0', 'english', '1;', '', '2;1;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php * 21/01/2019 18:36:02 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('teohare.popa', 'Teohare', 'Popa', '$2y$13$7b09e504259cca5d94203ui.fje1eebaJf0FvISe5jra99s4GBkrW', '[email protected]', '0', '1', '0', '0', 'english', '1;', '', '2;1;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php * 21/01/2019 18:35:52 - Query: INSERT INTO `teampass_users` (`login`,`name`,`lastname`,`pw`,`email`,`admin`,`gestionnaire`,`read_only`,`personal_folder`,`user_language`,`fonction_id`,`groupes_interdits`,`groupes_visibles`,`isAdministratedByRole`,`encrypted_psk`) VALUES ('teohare.popa', 'Teohare', 'Popa', '$2y$13$ba3edf6a333482c39aa4euFHcQlVQpYZVsJewu2WzMYJKo.W9KCJC', '[email protected]', '0', '0', '0', '0', 'english', '1;', '', '2;1;', NULL, '')<br />Error: Column 'isAdministratedByRole' cannot be null<br />@ /teampass/sources/users.queries.php

Log from the web-browser developer console (CTRL + SHIFT + i)

Insert the log here and especially the answer of the query that failed.

Jun 06 '22 09:06 KekSantiago

Nice idea

Jun 14 '22 11:06 nilsteampassnet