routingpy icon indicating copy to clipboard operation
routingpy copied to clipboard

supply **kwargs to all methods of all routers

Open nilsnolde opened this issue 4 years ago • 2 comments

in https://github.com/gis-ops/routing-py/pull/41#commitcomment-55187341 we realized that the **kwargs are not even used when they're passed to a method. instead of removing that parameter, we should make use of it and simply append the whole thing to the request parameters. reason is that we likely won't keep up here with all the changes of the individual router arguments to APIs which will be added in the future and this provides a means of passing those anyways, sort of a safety net for our (and the community's!!!) laziness;)

nilsnolde avatar Aug 20 '21 13:08 nilsnolde

This is exactly what I need! I've created PR adding kwargs support for osrm https://github.com/gis-ops/routing-py/pull/49

nurikk avatar Dec 15 '21 01:12 nurikk

Please help to review https://github.com/gis-ops/routing-py/pull/59

nurikk avatar Mar 15 '22 02:03 nurikk