protolock icon indicating copy to clipboard operation
protolock copied to clipboard

Deeply nested messages may conflict

Open zack-littke-smith-ai opened this issue 1 year ago • 2 comments

Hello! I've noticed an issue where a nested message may conflict with another. For example (forgive the terrible names and missing boilerplate):

message OutermostA {
  message Inner {
    enum Innermost {
      reserved 1;
    }
  }
}

message OutermostB {
  message Inner {
    enum Innermost {
      reserved 1;
    }
  }
}

We see a lock file where the names of both OutermostA.Inner.Innermost and OutermostB.Inner.Innermost are only Inner.Innermost and may conflict (like above)

zack-littke-smith-ai avatar Jan 10 '24 19:01 zack-littke-smith-ai

Hi @zack-littke-smith - is this level of nesting (enum nested 2 levels within a parent message) the first at which you notice the issue? Or does something like this also produce the same issue:

message Inner {
  enum Innermost {
     reserved 1;
  }
}

nilslice avatar Mar 24 '24 00:03 nilslice

I believe this only occurs in the nested case, would not be an issue in the example you provide

zack-littke-smith-ai avatar Apr 01 '24 16:04 zack-littke-smith-ai