ttrss-reader-fork icon indicating copy to clipboard operation
ttrss-reader-fork copied to clipboard
verified publisher icon nilsbraden

Swiping left to right on an article toggles its read state

Open lostmsu opened this issue 5 years ago • 4 comments

This implements #275

Refactored custom gesture listeners a bit. When a left-to-right swipe is performed on an article headline in a list, toggles article read state.

Currently this precludes any other behavior, that existed before this change.

I did not test the new swipe handler on anything but articles. Can happily do that if somebody can point me to test steps for feed navigation.

lostmsu avatar Oct 31 '20 06:10 lostmsu

I'm not sure I understood this correctly. Does this affect only the behaviour in FeedHeadlineView? And there it only changes what happens when you swipe left-to-right over one article (so not going diagonally but only straight), then the article is marked read, otherwise the normal fling behaviour is processed?

Not sure if this is practical actually. Maybe we should try to add some kind of visual feedback on this, it might lead to confusion otherwise.

nilsbraden avatar May 09 '21 16:05 nilsbraden

The visual feedback currently: the article changes read/unread mark after gesture is done.

I know feature is useful: I used it extensively before switching to TTRSS-Reader from Feedly.

Visual feedback would be nice, but frankly I am too lazy to program it )

lostmsu avatar May 09 '21 20:05 lostmsu

only changes what happens when you swipe left-to-right over one article (so not going diagonally but only straight), then the article is marked read, otherwise the normal fling behaviour is processed?

That sounds right. Though I do not know what the normal fling behavior is, so I never tested it.

lostmsu avatar May 09 '21 21:05 lostmsu

Any plans to merge these? I can fix the merge conflicts. Had to use my own fork for 3 years now for these two features.

lostmsu avatar Jul 02 '24 05:07 lostmsu

There are two things I am concerned about:

  1. This breaks normal swiping beahaviour which is: swipe left to switch to previous feed, right for next feed. So it needs to be a preference I guess since there is no simple way to distinguish between different ways of swiping that could be used as far as I see.

  2. It only works left-to-right but should be RTL-compatible eg. for arabic users. (I just noticed that the old implementation doesn't do that as well. Not such a big problem since the behaviour is of the same type for left and right swipe but should be improved anyway...)

I already merged the changes from this PR and will add a preference as soon as I find the time.

nilsbraden avatar Aug 12 '24 10:08 nilsbraden