auvlib icon indicating copy to clipboard operation
auvlib copied to clipboard

Only jsf parts of #60

Open nilsbore opened this issue 5 years ago • 4 comments

Cherry-picking the parts out of https://github.com/nilsbore/auvlib/pull/60 that are relevant for parsing jsf. The xtf parts that John have done will need a separate PR to figure out what is causing the windows build failure.

nilsbore avatar Aug 10 '20 14:08 nilsbore

@xyp8023 So these are only the jsf parts but it's still failing on windows for some reason. I've rebuilt the current master on CI and it's still building so it's not a problem with CI having been updated.

nilsbore avatar Aug 10 '20 14:08 nilsbore

Suspicion confirmed: https://github.com/nilsbore/auvlib/pull/63 builds.

nilsbore avatar Aug 10 '20 19:08 nilsbore

Maybe we can do something like this?:

if (MSVC AND ${MSVC_VERSION} GREATER_EQUAL 1915) target_compile_definitions( ${target_name} PRIVATE _ENABLE_EXTENDED_ALIGNED_STORAGE ) endif()

xyp8023 avatar Aug 26 '20 06:08 xyp8023

If that fixes the problem, that would be a good way to do it. Please open another PR with that change to see if it builds. Make sure to base it on the only_jsf branch.

nilsbore avatar Aug 26 '20 11:08 nilsbore