Nils Braun

Results 129 comments of Nils Braun

Very interesting! Thanks for the investigation. I am just wondering, why this is so different from now. Because the `groups = df_rolled.groupby('id', sort=False)` is also done internally (more or less)...

By the way: thank you for investigation so deeply and trying to solve the problem! Nice to see that people really want to push the boundaries!

Hi! As far as I know we did not. As I am not familiar with these features: if you think it makes sense to add them, would you like to...

Hi @nagiton Thanks for your bug report. Unfortunately, I can not reproduce the issue. I tried with the example data: ```python from tsfresh import extract_features from tsfresh.examples import load_robot_execution_failures df,...

Just if anyone is interested (slightly related): I posted about the scaling behavior of tsfresh here: https://nils-braun.github.io/execution-time/

Good catch! I understand your reasoning. Just a note: If it is actually a bias for your future ML model depends on the way you apply it in your test...

Ok, then good you raise this issue! Would you like to do a pull request? Maybe for the warning sentence or even for the better impute function? Maybe we could...

Great idea @mmcux! I like both your ideas (allow for multiple columns in the id as well as remove the created id, as it can be easily recreated). However, I...

Hi @Apsylem ! Sorry the review takes so long, I am a bit occupied in the moment. I will try to have a look in the next few days! Thank...

Thanks @Apsylem - the changes look good to me. Could you include the current main branch? We have now added styling with black using a pre-commit hook. I would propose...