php-json-api icon indicating copy to clipboard operation
php-json-api copied to clipboard

Silent DataException in DataObject

Open derrekbertrand opened this issue 9 years ago • 1 comments

https://github.com/nilportugues/php-json-api/blob/master/src/Server/Data/DataObject.php#L51

While testing some stuff out in the Laravel wrapper, I realized that you can trigger an exception here by setting the type to text instead of a JSON request. The data won't be filled out right, and the assert fails. Unfortunately, this line just eats the assertion, and happily lets it crash later.

derrekbertrand avatar Dec 12 '16 22:12 derrekbertrand

Look's like it is the Laravel wrapper's fault... partially. In non-debug mode, it dumps this message, but that doesn't really explain the error, just that your request setup is wrong.

Honestly, I think just commenting what that try-catch block does might help a lot.

{
  "errors": [
    {
      "status": 400,
      "title": "Bad Request",
      "detail": "Request could not be served."
    }
  ]
}

derrekbertrand avatar Dec 12 '16 22:12 derrekbertrand