Nil Portugués Calderó
Nil Portugués Calderó
Notice this is a recommendation, not an enforcement. Yet I agree a parameter could be set to take this into account and allow different conventions
Code related to the issue: **Repo** https://github.com/nilportugues/php-json-api/blob/master/src/JsonApiTransformer.php#L249 **Dependency** https://github.com/nilportugues/php-api-transformer/blob/master/src/Transformer/Transformer.php#L121
@GSokol This can be solved already, but code needs to be added in place before release. See https://github.com/nilportugues/php-json-api/commit/490b15f0a346ac989cf8e102d3aec2d2a1f059e3 Need to finish this release to allow this behaviour.
I believe it's stable but has no maintainance because the problem is fully solved.
I'm considering releasing this package as a PHP 8.2 and above, yeah.
Are you sure? There's a test for this already and it's passing: https://github.com/nilportugues/php-sitemap/blob/master/tests/SitemapTest.php#L101
@njentit mind creating a pull request and running this case as a tests? If all tests still pass I'm certain it's a bug and you just solved it.
@anthonykozak mind sharing with me the file so I can fix it? :+1: :)